Attention is currently required from: pespin.

lynxis lazus has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email )

Change subject: Initial S6b support
......................................................................


Patch Set 2:

(2 comments)

File src/aaa_diameter_s6b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/8b82f6f8_c96ac25c
PS2, Line 138: % APN is optional and should be []
old code?


https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858/comment/422af289_dd60ec07
PS2, Line 148:     SessionId = 
diameter:session_id(application:get_env(?ENV_APP_NAME, origin_host, 
?ENV_DEFAULT_ORIG_HOST)).
It looks you're missing something here.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/34858?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: Ia2b138317cb291a95882853f5403949c5e6a5a1b
Gerrit-Change-Number: 34858
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: lynxis lazus <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 23 Oct 2023 13:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to