Attention is currently required from: dexter, pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email )

Change subject: manuals: add section about the SGs interface.
......................................................................


Patch Set 1:

(3 comments)

File doc/manuals/chapters/sgs.adoc:

https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/f66de8d8_e1f96e55
PS1, Line 4: SGs/SGsAP
The interface is called SGs.  The application layer protocol for it is SGsAP.  
SO if you want to mention both and stay correct, you'd have to phrase it like 
"offers a SGs interface using the SGsAP protocol" or the like.


https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/4794f557_2275e5d8
PS1, Line 5: LTE/EPC
you used "2G (GERAN)" before, then here it would make sense to use the same 
format e.g. "4G (EUTRAN)" or if needed "4G (EUTRAN/LTE)"


https://gerrit.osmocom.org/c/osmo-msc/+/34870/comment/861d2b51_9da779e3
PS1, Line 44: In case multiple instances of OsmoMSC run in parallel, it is 
advised to use a
            : different vlr-name for each instance
you might want to add that they of course need to be bound to different IP 
addresses.  btw: the vlr-name is usually the DNS name for the IP address of 
that VLR/MSC, so they should agree.



--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34870?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: Ic7c17511ee19cb7f6d5069b27beb661ecb4b0be8
Gerrit-Change-Number: 34870
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Mon, 23 Oct 2023 16:07:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to