Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/5684/1/library/BSSMAP_Templates.ttcn File library/BSSMAP_Templates.ttcn: Line 651: return hex2oct(mcc[1] & mcc[0] & mcc[2] & mcc[2] & mnc[1] & mnc[0]); > mcc[2] twice? ... oh wait, this is ttcn, until I realized I was completely IIRC there is an 0xf involved ... seems to me we want what gsm48_construct_ra() does? libosmocore/src/gsm/gsm48.c -- To view, visit https://gerrit.osmocom.org/5684 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I99a5317e425d15acd463aa94c683676cacd54e0b Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-HasComments: Yes
