Patch Set 5: (2 comments)
https://gerrit.osmocom.org/#/c/5652/5/src/gb/gprs_bssgp.c File src/gb/gprs_bssgp.c: Line 256: gsm48_encode_ra((struct gsm48_ra_id *)buf, raid); This code could cause unaligned access on some hardware platforms because we do not know if 'buf' is already aligned. A memcpy(&ra_id, buf, sizeof(ra_id)) to a local struct gsm48_ra_id ra_id; variable and passing a pointer to that variable to gsm48_encode_ra() would avoid an unaligned access. https://gerrit.osmocom.org/#/c/5652/5/src/gsm/gsm48.c File src/gsm/gsm48.c: Line 703: Why was the comment removed? Without the comment (mnc < 100) becomes less obvious. -- To view, visit https://gerrit.osmocom.org/5652 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I31f9605277f4945f207c2c44ff82e62399f8db74 Gerrit-PatchSet: 5 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-HasComments: Yes
