Attention is currently required from: fixeria, laforge. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/34886?usp=email )
Change subject: ASCI: Add control of uplink access to osmo-bts-trx ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bts/+/34886/comment/fcb66f36_4df98ba7 PS1, Line 13: Change-Id: I9045437d52984b7abe00fbc815d7f83c62c0fb5a > `Depends: libosmocore.git Ibd6a1d468a70126a8f67e944fcb916969cc3c36b` […] Done File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/34886/comment/921313b4_e155de45 PS1, Line 1153: /* look for > AFAIR, in this context it means both main (DCCH/TCH) and associated (SACCH) > channels. […] According to GSM TS 05.02, both FACCH/SACCH can be used to send access bursts (uplink access or handover access). https://gerrit.osmocom.org/c/osmo-bts/+/34886/comment/d48a13ed_da7c4089 PS1, Line 1156: struct l1sched_ts *l1ts = lchan->ts->priv; > This pointer can be obtained only once outside of the loop. […] Yes, it may happen, because uplink access is activated before channel is activated. Just added the check here too. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/34886?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I9045437d52984b7abe00fbc815d7f83c62c0fb5a Gerrit-Change-Number: 34886 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Fri, 27 Oct 2023 09:33:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
