Attention is currently required from: arehbein, daniel.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email )

Change subject: logging_gsmtap: Temporarily disable logging when sending the 
logs
......................................................................


Patch Set 2:

(2 comments)

File src/core/logging_gsmtap.c:

https://gerrit.osmocom.org/c/libosmocore/+/34966/comment/97b4a79f_937de618
PS1, Line 117: the
> small addition (while we're at it): The verb is missing, so maybe sth. like 
> […]
Done


https://gerrit.osmocom.org/c/libosmocore/+/34966/comment/bdbd6fb9_709908d6
PS1, Line 119:  target->loglevel = LOGL_FATAL + 1;
> Unlike sub-systems, it's highly unlikely that we'd add log levels - I don't 
> think we ever have. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34966?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I19203cadbad6019a3834793b8ac816d903fe088e
Gerrit-Change-Number: 34966
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Attention: daniel <[email protected]>
Gerrit-Comment-Date: Tue, 07 Nov 2023 18:07:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: arehbein <[email protected]>
Comment-In-Reply-To: laforge <[email protected]>
Gerrit-MessageType: comment

Reply via email to