Attention is currently required from: fixeria, laforge, lynxis lazus. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email )
Change subject: hlr: add imsi unknown cause test case ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File hlr/HLR_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/292037c3_1e662445 PS2, Line 991: (i'm having a hard time to understand what the test does, maybe a brief comment?) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569/comment/bd8f92de_e66dc542 PS2, Line 1007: test the new test seems to separate two TC_gsup_ul_unknown_imsi* that wanted to be very close together. add the new tests one notch further below, like below where the 'execute' is in the perfect spot. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/27569?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I87c3a2d7304b81cfc11a364d933567e1a080b99a Gerrit-Change-Number: 27569 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Mon, 13 Nov 2023 03:11:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
