Patch Set 2: (1 comment)
https://gerrit.osmocom.org/#/c/5698/2/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: Line 348: lai.digits[0] = data[1 + i * sizeof(lai)]; > this is a really ugly/verbose way of manually copying individual bytes. why Agreed, a single memcpy() works just fine. Fixed in next patchset. -- To view, visit https://gerrit.osmocom.org/5698 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic3c62ff0fccea586794ea4b3c275a0685cc9326e Gerrit-PatchSet: 2 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-HasComments: Yes
