Attention is currently required from: arehbein, pespin.
neels has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )
Change subject: Introduce per-BTS timers, RLC timer commands
......................................................................
Patch Set 12: Code-Review-1
(1 comment)
Patchset:
PS12:
Hmm, the task this patch has is actually quite difficult, for these reasons:
- the osmo_tdefs API was implemented with T1234 and X1234 in mind, but not
N1234. Looks like we won't get around adding another namespace for N, in the
libosmocore tdef API itself. Mainly because T3101 and N3101 collide. (If it's
only this one maybe we want an ugly workaround instead? T23101 is N3101?).
Adding the 'N' category is a separate discussion, Vadim and I discussed it a
bit in PM and let's say there's potential for diverse opinions.
- the osmo_tdefs API was implemented with a single global timer config in mind,
not individual per-object timers. The tdefs API is modular enough to be helpful
in implementing this, so no problem here, just many choices to be made.
- confusion: we already have a global timer 'net' / 'T3101'; now we are also
adding a per-BTS T3101 as well as N3101. So per-BTS for GPRS, but only global T
for CS. And these seemingly identical T3101 items do not interact...? ("are you
sure they are separate?" / "did you really use the correct T3101?"...)
I'll not dive into per-line comments now, but I'd like to already say that we
need to still work on this patch (and it's not arehbein's fault)
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675
Gerrit-Change-Number: 31878
Gerrit-PatchSet: 12
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Wed, 15 Nov 2023 19:27:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
