Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35050?usp=email )
Change subject: add sdp_audio_codec_to_speech_codec_list() ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/libmsc/codec_mapping.c: https://gerrit.osmocom.org/c/osmo-msc/+/35050/comment/9f6fa8d4_c948ee2a PS1, Line 427: scl->len >= ARRAY_SIZE(scl->codec IMO, it would be more logical to perform this check first before the two other checks, but not critical. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35050?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I6ac23c54bc26939e048ff2df06eb987421cfb1c5 Gerrit-Change-Number: 35050 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Comment-Date: Fri, 17 Nov 2023 11:43:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
