Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email )

Change subject: BTS_Tests_LAPDm.TC_nr_seq_error: Fix test
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
I think this needs a more elaborate explanation. Why do we need to involve the 
(simulated) BSC here?  Shouldn't the LAPDm instaince in the BTS itself 
disconnect LAPDm and send a REL_IND to the BTS?  Note it's been ages since I 
last looked at any of this, but definitely we need some explanation in the 
commit log other than "fix ..."



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35047?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4cdff6ab607e158d4956a1bd87f74e9e75579cff
Gerrit-Change-Number: 35047
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Fri, 17 Nov 2023 14:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to