Attention is currently required from: jolly.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmocore/+/34986?usp=email )

Change subject: LAPDm: Add support for RTS based polling
......................................................................


Patch Set 10: Code-Review+1

(2 comments)

File src/gsm/lapdm.c:

https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/e268b0e3_44823ce9
PS10, Line 1619: i
array should be "const uint32_t *" as it's just read and never modified.


https://gerrit.osmocom.org/c/libosmocore/+/34986/comment/7ee541e2_3f9052f1
PS10, Line 1631: void lapdm_channel_set_t200_fn(struct lapdm_channel *lc, 
uint32_t *t200_fn_dcch, uint32_t *t200_fn_acch)
arrays should be "const uint32_t *" as it's just read and never modified.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34986?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I6ebe83f829d7751ea9de1d90eb478c7a628db64c
Gerrit-Change-Number: 34986
Gerrit-PatchSet: 10
Gerrit-Owner: jolly <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Comment-Date: Fri, 17 Nov 2023 14:19:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to