Attention is currently required from: daniel, neels. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email )
Change subject: LAPD: Add support for RTS based polling and T200 ...................................................................... Patch Set 9: (1 comment) File src/isdn/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/5214f616_13aa8ff8 PS9, Line 1939: if ((dl->lapd_flags & LAPD_F_RTS) && !llist_empty(&dl->tx_queue)) { > This looks a bit weird. […] This function is called not only from lapd_ph_rts_ind, but from various locations of the LAPD process. The !llist_empty() checks if there is already some message in the queue. (RTS mode can only handle one message at a time.) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib961b5a44911b99b0487641533301749c0286995 Gerrit-Change-Number: 34985 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: daniel <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Mon, 27 Nov 2023 09:35:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
