Attention is currently required from: arehbein.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email )

Change subject: Make BSSGP timing data configurable
......................................................................


Patch Set 5:

(1 comment)

File src/osmo-bsc/bts_vty.c:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-12662):
https://gerrit.osmocom.org/c/osmo-bsc/+/31882/comment/ca036c67_466958e6
PS5, Line 1755:         if (osmo_tdef_set(bts_bssgp->tdefs, 
tdef_params->tdef_id, (val * tdef_params->factor)? : 1, tdef_params->unit) < 0)
spaces required around that '?' (ctx:VxW)



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31882?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Id4779f033b5eb1742462d4efc28a0398645acfe6
Gerrit-Change-Number: 31882
Gerrit-PatchSet: 5
Gerrit-Owner: arehbein <arehb...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: arehbein <arehb...@sysmocom.de>
Gerrit-Comment-Date: Tue, 28 Nov 2023 09:48:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to