Attention is currently required from: fixeria, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email )

Change subject: Update git URLs
......................................................................


Patch Set 1: Verified+1

(4 comments)

File contrib/jenkins-build-osmo-bts.sh:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157/comment/8cfb5cd3_a235d146
PS1, Line 7: (git_url=https://gitea.osmocom.org/cellular-infrastructure
> sounds like you want to change the default git_url in have_repo or 
> jenkins-build-common. […]
It needs to be this url for octphy-2g-headers only (not on gerrit), everything 
else should be retrieved from gerrit.osmocom.org (as there is no sync delay). I 
only want to set git_url for this one call to have_repo, hence it is in a 
subshell.

Something similar is done already in contrib/jenkins-build-osmo-bts-oc2g.sh, 
contrib/jenkins-build-osmo-pcu-oc2g.sh, contrib/jenkins-build-osmo-trx.sh. I 
can use the same exact syntax if you prefer.

This was not necessary before, as octphy-2g-headers was reachable from 
git.osmocom.org too.


File src/osmo_gsm_tester/obj/osmo_vty.py:

https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157/comment/bcf0f78a_7cd9b4e1
PS1, Line 83:         # (copied from 
osmo-python-tests/osmopy/osmo_interact/vty.py)
> osmo-python-tests. […]
Done


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157/comment/0b4ecfaa_f1abde60
PS1, Line 162:         # (copied from 
osmo-python-tests/osmopy/osmo_interact/vty.py)
> osmo-python-tests. […]
Done


https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157/comment/638b1896_d1cbf381
PS1, Line 212:         # (copied from 
osmo-python-tests/osmopy/osmo_interact/vty.py)
> osmo-python-tests. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Change-Id: I03a06d23e87a75257eb731a97facd7a67c40a2c6
Gerrit-Change-Number: 35157
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Nov 2023 13:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to