Attention is currently required from: dexter, fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email )

Change subject: gprs_rlcmac_sched: rewrite logic around idle block skip
......................................................................


Patch Set 2:

(1 comment)

File src/gprs_rlcmac_sched.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/35151/comment/47256c5d_e54ac3a3
PS1, Line 486:                   * way we help BTS energy saving (on TRX!=C0) 
by sending nothing
> Was this ever tested?

Not myself, but I'd expect them to transmit nothing or whatever? maybe 
@lafo...@osmocom.org can say from the top of his head since he knows better 
that l1 part.

It makes sense that it sends nothing, and hence why we have to force it to 
transmit a dummy rlcmac block on trx0.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Iadb62748b18605bf158169b317f880352bc0a5a6
Gerrit-Change-Number: 35151
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: dexter <pma...@sysmocom.de>
Gerrit-Comment-Date: Wed, 29 Nov 2023 16:37:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: dexter <pma...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to