Attention is currently required from: lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35218?usp=email )

Change subject: epdg_gtpc_s2b: add TLV Serving Network
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File src/epdg_gtpc_s2b.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35218/comment/d0a6f587_8f0bba15 
PS1, Line 338:                     plmn_id = gtp_utils:plmn_to_bin(?MCC, ?MNC, 
?MNC_SIZE)
this will need to come from CEAI interface at some point? from strongswan I 
mean. Or maybe as a config option?



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35218?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I2a9459859fc660e6433cd8178ab9d1f92ae74fc0
Gerrit-Change-Number: 35218
Gerrit-PatchSet: 1
Gerrit-Owner: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: lynxis lazus <lyn...@fe80.eu>
Gerrit-Comment-Date: Tue, 05 Dec 2023 12:13:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to