Attention is currently required from: laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35205?usp=email )
Change subject: IuUP: allow Initialization from any address if not yet set ...................................................................... Patch Set 3: (2 comments) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35205/comment/f6fdee5b_ff892409 PS1, Line 838: if (mgcp_conn_rtp_is_iuup(conn) && !conn->iuup.configured) { > Re the linked patch, I see only address and port related code in that patch, > nothing about codecs no […] 1) Yes, we used to always add the codec in CRCX in that scenario, but with my libosmo-mgcp-client in gerrit we didn't. I already changed again that patch to include the codec. 2) Yes we can, but since we want to send a tentative remote address in the first CRCX, then we need to add the SDP instead. 3) This is precisely how all this patchset started: we want to send a remote IP address on the RAN-side conn during first CRCX so that osmo-mgw's "ip probing" can potentially bind to the correct local IP address and provide it in CRCX ACK. osmo-hnbgw will use the remote Iuh IP address (HNB's Iuh IP addr) as a remote IuUP address in the first CRCX, which is usually correct. In the event it wasn't, during rx RAB-Ass-Resp it will send an MDCX to the MGW, and the MGW will update the address. We can ofc only guess the IP address, not the port. And even the IP address may be wrong, hence why we neeed to accept rx of IuUP Init from any source. File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35205/comment/dcefeb85_7fe3e76f PS2, Line 837: != 0) > (... […] in the resulting code execution yes, but this way also provides more info that errors may occur and how are they handled, eg AF_UNSPEC. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I6c365559a7bd197349f0ea99f7a13b56a4bb580b Gerrit-Change-Number: 35205 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Wed, 06 Dec 2023 11:54:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
