Attention is currently required from: pespin.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-netif/+/35240?usp=email )

Change subject: stream: Use new multiaddr APIs to log whole set of sock 
addresses
......................................................................


Patch Set 4:

(1 comment)

Patchset:

PS4:
I'm wondering if we really want to store/display/... those absurdly long 
strings consisting of all the socket addresses here.

It's fine if there is a single VTY command that shows the user all the gory 
detail.  But having potentially hundreds of characters as prefix in a log 
message? I don't really think this is where we want to move.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/35240?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I7ae300595825836cc7d6fa07238c0c2f15d14e85
Gerrit-Change-Number: 35240
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: laforge <lafo...@osmocom.org>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 07 Dec 2023 13:25:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to