Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email )
Change subject: add fmtp string to ptmap: allow all possible fmtp ...................................................................... Patch Set 10: (3 comments) File include/osmocom/mgcp/fmtp.h: https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/09d33fc1_163b5854 PS10, Line 1: #pragma once > libosmocore is too generic for mgcp specific stuff. […] ok, will try that File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/8e78d209_ad654820 PS6, Line 1372: ! > == (somehow gerrit lost the right place for this. the == is below.) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/34900/comment/3ab13f10_31029c60 PS9, Line 1290: && (mgcp_msg->ptmap[i].codec == CODEC_AMR_8000_1 > (fact: the problem with the "&&" at the start of the line instead of > appending at the end of last on […] - it's much more efficient to read the condition with operators at the start. at the start, they are in a fixed position, and form a tree structure (akin to a file tree view) with the operators as the node bullets. With operators at the end, the eye needs to scan around. - the loss of indent happens only once per logical branch in the condition and is only 3 chars... i would very much like to continue using this structuring in my conditions. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: If58590bda8627519ff07e0b6f43aa47a274f052b Gerrit-Change-Number: 34900 Gerrit-PatchSet: 10 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2023 01:46:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
