Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/35354?usp=email )
Change subject: iu_client: Handle empty CR and InitialUE Message in DATA.ind ...................................................................... Patch Set 1: (6 comments) File src/iu_client.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099): https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/fd14000f_ecaae644 PS1, Line 180: static void ue_conn_sccp_addr_add(uint32_t conn_id, const struct osmo_sccp_addr *calling_addr) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099): https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/97e6f0cc_25602fd3 PS1, Line 189: static const struct osmo_sccp_addr *ue_conn_sccp_addr_find(uint32_t conn_id) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099): https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/74971f2e_620ebf20 PS1, Line 192: if (entry->conn_id == conn_id) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099): https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/1dacde76_ef20c1c5 PS1, Line 199: static void ue_conn_sccp_addr_del(uint32_t conn_id) { open brace '{' following function definitions go on the next line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099): https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/affd1729_5e710e86 PS1, Line 931: "N-DATA.ind for unknown conn_id (%u)\n", conn_id); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-13099): https://gerrit.osmocom.org/c/osmo-iuh/+/35354/comment/b846dfaf_cd407be3 PS1, Line 931: "N-DATA.ind for unknown conn_id (%u)\n", conn_id); please, no space before tabs -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/35354?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: I749ede737b9ac15bca37bbb16f3988b0db1125c1 Gerrit-Change-Number: 35354 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillm...@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 13 Dec 2023 16:42:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment