Attention is currently required from: arehbein, fixeria, laforge, neels.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )

Change subject: Introduce per-BTS timers, RLC timer commands
......................................................................


Patch Set 18: Code-Review-1

(2 comments)

Patchset:

PS18:
Some of my previous comments haven't been addressed.


File tests/bts_features.vty:

https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/2662ad2e_c1d4bc20
PS18, Line 66: OsmoBSC(config-net-bts)# gprs show timer
this is unexpected from user point of view. Users expect all commands showing 
state of stuff to start with "show", then press TAB to see the possibilities.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I2c24110d8c977d6cc74c3c8e77bcc709ad9d2675
Gerrit-Change-Number: 31878
Gerrit-PatchSet: 18
Gerrit-Owner: arehbein <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: arehbein <[email protected]>
Gerrit-Attention: neels <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Thu, 14 Dec 2023 12:32:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to