Attention is currently required from: dexter, fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/35254?usp=email )

Change subject: tlv: improve flatten_dict_lists for multiple keys
......................................................................


Patch Set 2:

(1 comment)

Patchset:

PS2:
is this fixing a different isue than the below patch that was recently merged 
to master?

commit 880db3735689b7cc0b7bb0b826b8acd4bf02dcc2
Author: Harald Welte <[email protected]>
Date:   Wed Dec 6 09:01:00 2023 +0100

    flatten_dict_lists(): Don't flatten lists with duplicate keys

    If we have a list of dicts, and we flatten that into a dict: Only
    do that if there are no dicts with duplocate key values in the list,
    as otherwise we will loose information during the transformation.

    Change-Id: I7f6d03bf323a153f3172853a3ef171cbec8aece7
    Closes: OS#6288



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35254?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie3b418ca3965b0221bbf5f85d7d0e0fbb39d9d87
Gerrit-Change-Number: 35254
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Sun, 17 Dec 2023 13:08:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to