Attention is currently required from: arehbein, fixeria, laforge, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email )
Change subject: tests: Test gsmtap logging if write queue fills up ...................................................................... Patch Set 3: (5 comments) File tests/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/b76ccc94_bd49d1b5 PS2, Line 18: logging/logging_test_gsmtap > This file needs to be updated properly: […] Done https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/a19cb23e_29d84576 PS2, Line 566: logging/logging_test > add the respective statement for `logging_test_gsmtap` here Done File tests/logging/logging_test_gsmtap.c: https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/673690cd_7398e8ee PS2, Line 3: 2008, 2009 by Holger Hans Peter Freyther <[email protected]> > I doubt it was Holger who wrote this test He was the spiritual author but I get your point File tests/logging/logging_test_gsmtap.err: https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/7ea7b0ba_1e827898 PS2, Line 108: 0x611000000328 > I think we do patch stuff in output in some places already. […] Thanks for the hint. It's even easier now since we're using the txqueue of osmo_io and it doesn't log any pointers. File tests/testsuite.at: https://gerrit.osmocom.org/c/libosmocore/+/34967/comment/60bbad5a_5646f7a1 PS2, Line 206: logging_test_gsmtap.ok > no such file? Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id5ae0c4c3820a9ed59eaf4003d2c57b6bdfe3468 Gerrit-Change-Number: 34967 Gerrit-PatchSet: 3 Gerrit-Owner: daniel <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arehbein <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: arehbein <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 18 Dec 2023 11:03:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
