Attention is currently required from: pespin.

neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email )

Change subject: mgw: do not fail MGCP on codec mismatch
......................................................................


Patch Set 5:

(1 comment)

File src/libosmo-mgcp/mgcp_codec.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/35302/comment/a7f1fb18_7f893f77
PS1, Line 478:  LOGP(DLMGCP, LOGL_ERROR, "no matching codec found\n");
> This one has not been addressed.
or i can drop this log again, it was from debugging.
btw, it seems osmo-mgw does a lot of context-less logging in MGCP and SDP.

re unadressed: I probably just pushed a later patch, causing a new patch set 
here too -- no intention to skip CR still marked unresolved



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35302?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: I3d1163fe622bdd7dc42a485f796072524ab39db9
Gerrit-Change-Number: 35302
Gerrit-PatchSet: 5
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 04 Jan 2024 23:33:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to