Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35421?usp=email )
Change subject: client SDP: more verbose error logging ...................................................................... Patch Set 1: (2 comments) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35421/comment/4b9f502b_43a4d7bf PS1, Line 376: LOGP(DLMGCP, LOGL_ERROR, > it would be the other one below, with the "_pt:" label... Done https://gerrit.osmocom.org/c/osmo-mgw/+/35421/comment/1fe4df57_b62da484 PS1, Line 382: "Failed to parse SDP parameter payload types (%s)\n", line); > ...this one. […] to recap, I don't agree with dropping log of the SDP string that failed. i'd just leave it as it is, but we could reduce to INFO or DEBUG now? let me know or i'll resolve this soon. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35421?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ibc6343db82281789004c140ba98d99e5f6f73d83 Gerrit-Change-Number: 35421 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Thu, 04 Jan 2024 23:55:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
