Attention is currently required from: fixeria.

Hoernchen has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/35550?usp=email )

Change subject: test: adjust for libosmocore loglevel cache
......................................................................


Patch Set 1:

(1 comment)

File tests/handover/handover_test.c:

https://gerrit.osmocom.org/c/osmo-bts/+/35550/comment/31430458_4d1a7579
PS1, Line 73: osmo_stderr_target->categories[DHO].loglevel = LOGL_DEBUG;
> So, if accessing the logging internals is a bad idea (as you mentioned in the 
> related patch), then w […]
Because this unrelated and it is test code, test code is always weird/old and 
rarely does things normal code "should" do things.

In theory callers of the cache update func "should" hold a vty lock, but this 
does not matter in this case, because there can't really be any other threads...



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/35550?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ie9c546210bc554843b1029afa20965bde1d7f228
Gerrit-Change-Number: 35550
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <ew...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Thu, 11 Jan 2024 18:00:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to