laforge has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/35596?usp=email )

Change subject: vty: show mscs: tweak output
......................................................................

vty: show mscs: tweak output

Make the output more readable and split it over two lines, in
preparation to add more information in the next patch.

Before:

  OsmoBSC> show mscs
  0 m3ua RI=SSN_PC,PC=0.23.3,SSN=BSSAP RI=SSN_PC,PC=0.23.1,SSN=BSSAP

After:

  OsmoBSC> show mscs
  MSC 0: RI=SSN_PC,PC=0.23.3,SSN=BSSAP <-> RI=SSN_PC,PC=0.23.1,SSN=BSSAP
         ASP protocol: m3ua

Related: OS#6741
Change-Id: I70ad1b0f44f2a923248f4e3259747cb3fec98fd2
---
M src/osmo-bsc/bsc_vty.c
1 file changed, 28 insertions(+), 2 deletions(-)

Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified




diff --git a/src/osmo-bsc/bsc_vty.c b/src/osmo-bsc/bsc_vty.c
index 925f21f..27ceae4 100644
--- a/src/osmo-bsc/bsc_vty.c
+++ b/src/osmo-bsc/bsc_vty.c
@@ -3250,13 +3250,15 @@
 {
        struct bsc_msc_data *msc;
        llist_for_each_entry(msc, &bsc_gsmnet->mscs, entry) {
-               vty_out(vty, "%d %s %s ",
+               vty_out(vty, "MSC %d: %s <-> ",
                        msc->a.cs7_instance,
-                       osmo_ss7_asp_protocol_name(msc->a.asp_proto),
                        osmo_sccp_inst_addr_name(msc->a.sccp, 
&msc->a.bsc_addr));
                vty_out(vty, "%s%s",
                        osmo_sccp_inst_addr_name(msc->a.sccp, &msc->a.msc_addr),
                        VTY_NEWLINE);
+               vty_out(vty, "       ASP protocol: %s%s",
+                       osmo_ss7_asp_protocol_name(msc->a.asp_proto),
+                       VTY_NEWLINE);
        }

        return CMD_SUCCESS;

--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35596?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I70ad1b0f44f2a923248f4e3259747cb3fec98fd2
Gerrit-Change-Number: 35596
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged

Reply via email to