Attention is currently required from: jolly, tnt.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email )

Change subject: Add functions to events from server to client
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

File src/e1d.h:

https://gerrit.osmocom.org/c/osmo-e1d/+/35558/comment/a886cb93_14e1c058
PS1, Line 199:  void *srv;
> Yeah I saw later, but you can still use `struct osmo_e1dp_server *srv` (with 
> appropriate pre-declara […]
I agree with tnt here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35558?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-e1d
Gerrit-Branch: master
Gerrit-Change-Id: I5ee3268f8349b611c3cf3fa0572dc5eab280ab2e
Gerrit-Change-Number: 35558
Gerrit-PatchSet: 3
Gerrit-Owner: jolly <andr...@eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: tnt <t...@246tnt.com>
Gerrit-Attention: jolly <andr...@eversberg.eu>
Gerrit-Attention: tnt <t...@246tnt.com>
Gerrit-Comment-Date: Thu, 18 Jan 2024 08:55:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: jolly <andr...@eversberg.eu>
Comment-In-Reply-To: tnt <t...@246tnt.com>
Gerrit-MessageType: comment

Reply via email to