Attention is currently required from: laforge, lynxis lazus, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604?usp=email )

Change subject: GSUP_Types: Add missing message_class to EPDGTunnel* messages
......................................................................


Patch Set 2:

(2 comments)

File library/GSUP_Types.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604/comment/a0c30a0c_a91ab5ef
PS2, Line 1433: ts_GSUP_IE_Message_Class
Likewise here and above.


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604/comment/93a2ab51_3426d397
PS2, Line 1469: tr_GSUP_IE_Message_Class
This IE go before the `Source Name IE`, otherwise the template won't match 
messages generated by libosmocore's encoder.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35604?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ib7d6156402645867cadc8d3e0ffdd07247a1abd2
Gerrit-Change-Number: 35604
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Thu, 18 Jan 2024 17:24:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to