Attention is currently required from: fixeria, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35625?usp=email )
Change subject: gsm_04_08_gprs.h: Introduce packed struct gsm48_pdp_address ...................................................................... Patch Set 1: (3 comments) File include/osmocom/gsm/protocol/gsm_04_08_gprs.h: https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/9303be16_5169f617 PS1, Line 316: uint8_t organization:4, /* enum gsm48_pdp_type_org */ > alignment issues Ack https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/f3c8b0eb_178a386c PS1, Line 337: uint32_t v4; > likewise, alignment issues Ack https://gerrit.osmocom.org/c/libosmocore/+/35625/comment/70b6627f_123c0666 PS1, Line 340: ietf > So the total size of this union is 20 (determined by size of `v4v6`). […] Yeah you cannot do that, but I don't see it being a problem. I already introduced/used this kind of packed struct in open5gs and I found it quite useful, I tink it really makes sense to have it here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35625?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I453ced42dd36df3a6ddb5db67093df5a22cad18c Gerrit-Change-Number: 35625 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Fri, 19 Jan 2024 23:29:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
