Attention is currently required from: laforge, pespin.

osmith has posted comments on this change. ( 
https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email )

Change subject: ttcn3-epdg: Run osmo-epdg with CAP_NET_ADMIN
......................................................................


Patch Set 2:

(2 comments)

File ttcn3-epdg-test/jenkins.sh:

https://gerrit.osmocom.org/c/docker-playground/+/35607/comment/cffbab75_7d644ffc
PS2, Line 26:           --cap-add=NET_ADMIN --device /dev/net/tun:/dev/net/tun \
could you put one parameter in one line?


https://gerrit.osmocom.org/c/docker-playground/+/35607/comment/3455435e_65134111
PS2, Line 28:           -v /sys/fs/cgroup:/sys/fs/cgroup:ro \
why do you need to forward /sys/fs/cgroup?

(This caused problems in the past, a previous version of the repo install test 
used a similar hack to get systemd working inside the chroots. but this wasn't 
supported by systemd/docker and stopped working at one point. IIRC having 
different cgroups versions on host and in the container also caused problems.)



--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35607?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I48eea0e8d7969cc0a3ad2ed08f696decf064c474
Gerrit-Change-Number: 35607
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 22 Jan 2024 10:00:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to