Attention is currently required from: fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35640?usp=email )

Change subject: mobile: handle V.24 line status updates from V.110 TA
......................................................................


Patch Set 4:

(1 comment)

File src/host/layer23/src/mobile/tch_data.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/35640/comment/d18acff1_e7e7b1ea
PS2, Line 210:          LOGP(DL1C, LOGL_NOTICE, "V.110 TA circuit %s (%s) is 
%s\n",
> I agree in genral, but I don't expect the circuit state to change too often, 
> unless the flow control […]
RTS/CTS flow control will happen *all the time* in any realistic scenario where 
you have a backlog of to be transmitted data.  This is nothing a user ever 
wants to read about.

If you need higher log priority for things like DTR, then you have to 
differentiate between those two.  But for normal flow control it  should 
definitely not be anything > DEBUG.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35640?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I05ba2e10fefe3cae687831b5ced971aa244ad336
Gerrit-Change-Number: 35640
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Wed, 24 Jan 2024 08:38:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to