Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35731?usp=email )
Change subject: add SAIP template handling + v3.1 definitions ...................................................................... Patch Set 1: (2 comments) File pySim/esim/saip/templates.py: https://gerrit.osmocom.org/c/pysim/+/35731/comment/340bdd2f_3d7eb992 PS1, Line 23: __init__ > cosmetic: too many params, may of which are optional. I would go for `**kw` > here: […] i prefer if i can see the parameters in the method declaration and don't have to read through the body to see what kind of arguments are supported by a given method. https://gerrit.osmocom.org/c/pysim/+/35731/comment/7f39380d_b18f9491 PS1, Line 531: FilesUsimDf5GSv2 > duplicate definition yeah, actually the first definition above is the culprit, it should be FilesUsimDf5GS and this one remains v2. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35731?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I79bc0a480450ca2de4b687ba6f11d0a4ea4f14c8 Gerrit-Change-Number: 35731 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 29 Jan 2024 07:09:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
