Attention is currently required from: matanp. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/35747?usp=email )
Change subject: ctrl: Add ms power ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-bsc/+/35747/comment/69b475df_cf9f8d5f PS3, Line 7: ctrl: Add ms power Please add at least a brief description for the command(s) you're adding. Something like: "this new command allows you to control MS power level for a specific logical channel". I would also point out that the effect of this command may differ depending on whether you have `static` or `dynamic` MS power control. For `static` it would instruct the MS to transmit at the requested power level. However, for `dynamic` it would simply limit the maximum power level and not necessarily affect the actual MS power level. File src/osmo-bsc/bts_trx_ts_lchan_ctrl.c: https://gerrit.osmocom.org/c/osmo-bsc/+/35747/comment/1b529b9d_4b01533a PS3, Line 2: * (C) 2013-2015 by Holger Hans Peter Freyther : * (C) 2013-2022 by looks like you're missing to update the copyright header -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/35747?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I6f556b66011be6126d6bac31a14101ba37f81cc4 Gerrit-Change-Number: 35747 Gerrit-PatchSet: 3 Gerrit-Owner: matanp <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: matanp <[email protected]> Gerrit-Comment-Date: Tue, 30 Jan 2024 20:07:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
