Attention is currently required from: dexter, fixeria.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/35764?usp=email )

Change subject: Add global_platform shell command establish_scp02 and 
release_scp
......................................................................


Patch Set 5:

(1 comment)

Patchset:

PS5:
one of the problems here is that this code only adds it to the GlobalPlatform 
SecurityDomain class.  I think in reality it might be legal for any application 
to have its own set of SCP02 keys and hence we should permit the shell commands 
not just after selecting a security domain.

I guess we can leave it for now and solve that at a later point, when the 
feature is needed.



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35764?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib2f3c8f0563f81a941dd55b97c9836e3a6856407
Gerrit-Change-Number: 35764
Gerrit-PatchSet: 5
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Attention: dexter <[email protected]>
Gerrit-Comment-Date: Thu, 01 Feb 2024 11:46:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to