Attention is currently required from: fixeria, laforge.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/35795?usp=email )

Change subject: cosmetic: rename OSMO_SS7_ASP_PROT_M3UA[_SCTP]
......................................................................


Patch Set 1:

(2 comments)

Patchset:

PS1:
I think this patch can be actually dropped?


File examples/sccp_demo_user.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35795/comment/ecabf819_81bc8ba9
PS1, Line 188:  enum osmo_ss7_asp_protocol protocol = 
OSMO_SS7_ASP_PROT_M3UA_SCTP;
I'd leave the existing proto as it is, since the regular one is expected to be 
over SCTP.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35795?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Ife0ae7a4956980da40ee045b0b7eb5cd0ccd1aef
Gerrit-Change-Number: 35795
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: fixeria <[email protected]>
Gerrit-Comment-Date: Sat, 03 Feb 2024 01:20:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to