laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/35815?usp=email )
Change subject: pylint: profile.py ...................................................................... pylint: profile.py pySim/profile.py:169:0: C0325: Unnecessary parens after 'assert' keyword (superfluous-parens) pySim/profile.py:189:8: W0107: Unnecessary pass statement (unnecessary-pass) pySim/profile.py:197:8: W0107: Unnecessary pass statement (unnecessary-pass) pySim/profile.py:27:0: C0411: standard import "import abc" should be placed before "from pySim.commands import SimCardCommands" (wrong-import-order) pySim/profile.py:28:0: C0411: standard import "import operator" should be placed before "from pySim.commands import SimCardCommands" (wrong-import-order) pySim/profile.py:29:0: C0411: standard import "from typing import List" should be placed before "from pySim.commands import SimCardCommands" (wrong-import-order) Change-Id: Ifd55e8ab5ab04da06c8d11e50bc15740580b2900 --- M pySim/profile.py 1 file changed, 20 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/15/35815/1 diff --git a/pySim/profile.py b/pySim/profile.py index 0d09e81..74946ba 100644 --- a/pySim/profile.py +++ b/pySim/profile.py @@ -21,13 +21,13 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. # -from pySim.commands import SimCardCommands -from pySim.filesystem import CardApplication, interpret_sw -from pySim.utils import all_subclasses import abc import operator from typing import List +from pySim.commands import SimCardCommands +from pySim.filesystem import CardApplication, interpret_sw +from pySim.utils import all_subclasses def _mf_select_test(scc: SimCardCommands, cla_byte: str, sel_ctrl: str, @@ -166,7 +166,7 @@ return None def add_addon(self, addon: 'CardProfileAddon'): - assert(addon not in self.addons) + assert addon not in self.addons # we don't install any additional files, as that is happening in the RuntimeState. self.addons.append(addon) @@ -186,7 +186,6 @@ self.desc = kw.get("desc", None) self.files_in_mf = kw.get("files_in_mf", []) self.shell_cmdsets = kw.get("shell_cmdsets", []) - pass def __str__(self): return self.name @@ -194,4 +193,3 @@ @abc.abstractmethod def probe(self, card: 'CardBase') -> bool: """Probe a given card to determine whether or not this add-on is present/supported.""" - pass -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35815?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifd55e8ab5ab04da06c8d11e50bc15740580b2900 Gerrit-Change-Number: 35815 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-MessageType: newchange
