laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/35825?usp=email )
Change subject: pylint: apdu_source/__init__.py
......................................................................
pylint: apdu_source/__init__.py
pySim/apdu_source/__init__.py:1:0: C0114: Missing module docstring
(missing-module-docstring)
pySim/apdu_source/__init__.py:17:8: W0107: Unnecessary pass statement
(unnecessary-pass)
pySim/apdu_source/__init__.py:34:16: W0133: Exception statement has no effect
(pointless-exception-statement)
Change-Id: Iec552afd6004b849132132642910a4c7f91e3473
---
M pySim/apdu_source/__init__.py
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/25/35825/1
diff --git a/pySim/apdu_source/__init__.py b/pySim/apdu_source/__init__.py
index 098d3ca..99df865 100644
--- a/pySim/apdu_source/__init__.py
+++ b/pySim/apdu_source/__init__.py
@@ -14,7 +14,6 @@
@abc.abstractmethod
def read_packet(self) -> PacketType:
"""Read one packet from the source."""
- pass
def read(self) -> Union[Apdu, CardReset]:
"""Main function to call by the user: Blocking read, returns Apdu or
CardReset."""
@@ -31,5 +30,5 @@
elif isinstance(r, CardReset):
apdu = r
else:
- ValueError('Unknown read_packet() return %s' % r)
+ raise ValueError('Unknown read_packet() return %s' % r)
return apdu
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35825?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iec552afd6004b849132132642910a4c7f91e3473
Gerrit-Change-Number: 35825
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-MessageType: newchange
