laforge has uploaded this change for review. (
https://gerrit.osmocom.org/c/pysim/+/35838?usp=email )
Change subject: pylint: cdma_ruim.py
......................................................................
pylint: cdma_ruim.py
pySim/cdma_ruim.py:30:0: W0401: Wildcard import construct (wildcard-import)
pySim/cdma_ruim.py:188:4: W0237: Parameter 'data_hex' has been renamed to
'resp_hex' in overriding 'CardProfileRUIM.decode_select_response' method
(arguments-renamed)
pySim/cdma_ruim.py:30:0: C0411: third party import "from construct import *"
should be placed before "from pySim.utils import *" (wrong-import-order)
Change-Id: I4c384f37a6a317c6eddef8742572fcfa76a5fc20
---
M pySim/cdma_ruim.py
1 file changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/35838/1
diff --git a/pySim/cdma_ruim.py b/pySim/cdma_ruim.py
index ad50e60..d16aefc 100644
--- a/pySim/cdma_ruim.py
+++ b/pySim/cdma_ruim.py
@@ -19,6 +19,8 @@
import enum
+from construct import Bytewise, BitStruct, BitsInteger, Struct, FlagsEnum
+
from pySim.utils import *
from pySim.filesystem import *
from pySim.profile import match_ruim
@@ -27,7 +29,6 @@
from pySim.ts_51_011 import DF_TELECOM, DF_GSM
from pySim.ts_51_011 import EF_ServiceTable
from pySim.construct import *
-from construct import *
# Mapping between CDMA Service Number and its description
@@ -185,9 +186,9 @@
sel_ctrl="0000", files_in_mf=[DF_TELECOM(), DF_GSM(),
DF_CDMA()])
@staticmethod
- def decode_select_response(resp_hex: str) -> object:
+ def decode_select_response(data_hex: str) -> object:
# TODO: Response parameters/data in case of DF_CDMA (section 2.6)
- return CardProfileSIM.decode_select_response(resp_hex)
+ return CardProfileSIM.decode_select_response(data_hex)
@staticmethod
def match_with_card(scc: SimCardCommands) -> bool:
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/35838?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I4c384f37a6a317c6eddef8742572fcfa76a5fc20
Gerrit-Change-Number: 35838
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-MessageType: newchange
