laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35834?usp=email )
Change subject: pylint: esim/saip/personalization.py ...................................................................... pylint: esim/saip/personalization.py pySim/esim/saip/personalization.py:104:0: W0311: Bad indentation. Found 17 spaces, expected 16 (bad-indentation) pySim/esim/saip/personalization.py:105:0: W0311: Bad indentation. Found 17 spaces, expected 16 (bad-indentation) pySim/esim/saip/personalization.py:151:0: C0305: Trailing newlines (trailing-newlines) pySim/esim/saip/personalization.py:36:4: C0204: Metaclass class method __new__ should have 'mcs' as first argument (bad-mcs-classmethod-argument) pySim/esim/saip/personalization.py:56:4: W0237: Parameter 'pe_seq' has been renamed to 'pes' in overriding 'Iccid.apply' method (arguments-renamed) pySim/esim/saip/personalization.py:19:0: W0611: Unused Optional imported from typing (unused-import) Change-Id: I70b3e266bbafabbfcec3d48027d50b45c2c17809 --- M pySim/esim/saip/personalization.py 1 file changed, 18 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index cb3edc1..fd83387 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -16,7 +16,7 @@ # along with this program. If not, see <http://www.gnu.org/licenses/>. import abc -from typing import List, Tuple, Optional +from typing import List, Tuple from pySim.esim.saip import ProfileElement, ProfileElementSequence @@ -47,7 +47,7 @@ self.value = value @abc.abstractmethod - def apply(self, pe_seq: ProfileElementSequence): + def apply(self, pes: ProfileElementSequence): pass class Iccid(ConfigurableParameter): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/35834?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I70b3e266bbafabbfcec3d48027d50b45c2c17809 Gerrit-Change-Number: 35834 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-MessageType: merged
