Attention is currently required from: jolly, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email )

Change subject: mobile: init TCH state earlier (on receipt of CC ALERTING)
......................................................................


Patch Set 1:

(4 comments)

Commit Message:

https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/9f6dcbb5_eddff0b7
PS1, Line 9: The MS would usually start receiving traffic indications with
> I'm not really understanding the patch together with the commit description. 
> […]
I've updated the COMMIT_MSG, hope it's better now.


https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/4eda016a_c132c67a
PS1, Line 10: dial tone
> ringback tone
Done


File src/host/layer23/src/mobile/tch.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/855a65d4_0bb2dacd
PS1, Line 184: GSM_CSTATE_CALL_DELIVERED
> No traffic during data call. Maybe activate data call traffic when call is 
> connected. […]
Done


https://gerrit.osmocom.org/c/osmocom-bb/+/35739/comment/d8a857d9_c7bebaa3
PS1, Line 185: GSM_CSTATE_CALL_RECEIVED:
> there is no audio in any direction while the phone (mobile terminated call) 
> is ringing.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35739?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idd32c823639cc1f9999d77fcefe7e260e31a85ec
Gerrit-Change-Number: 35739
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: jolly <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Attention: jolly <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Mon, 05 Feb 2024 18:05:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: jolly <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to