Attention is currently required from: laforge, lynxis lazus.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901?usp=email )

Change subject: Make PDP-Type and APN from GSUP AuthInfoReq available through 
all layers
......................................................................


Patch Set 1:

(1 comment)

File src/aaa_diameter_swx.erl:

https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901/comment/a638af84_7f39e2bd
PS1, Line 192:     %16#21 ->
idk why, if it go through this path, I get an encode error:

    18:13:36.308 [debug] Swx MAR: IPv4Opt=<<"<FF><FF><FF><FE>">> IPv6Opt=[]
    *DBG* aaa_ue_fsm_262420000000001 send {error,encode} to <0.174.0>
    *DBG* aaa_ue_fsm_262420000000001 consume call {swm_auth_req,33,"internet"} 
from <0.174.0> in state state_new
    18:13:36.329 [error] Error: encode

Maybe I'm encoding wrong an OctetString? Quick check in 
https://www2.erlang.org/documentation/doc-10.5/lib/diameter-2.2.1/doc/html/diameter_dict.html#DATA_TYPES
 says:

    OctetString() = string() | binary()


Maybe I need to encode it as a 4 int tuple, as explained in "Derived AVP Data 
Formats" section just below the line I shared above.



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/35901?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I3f29b00f57f433f8623b9f0a5048c83985e5cced
Gerrit-Change-Number: 35901
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: lynxis lazus <[email protected]>
Gerrit-Comment-Date: Wed, 07 Feb 2024 18:26:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to