neels has submitted this change. (
https://gerrit.osmocom.org/c/osmo-msc/+/35876?usp=email )
(
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted
one.
)Change subject: cosmetic: tweak sdp_audio_codecs_by_payload_type()
......................................................................
cosmetic: tweak sdp_audio_codecs_by_payload_type()
No functional change, only more readable code.
Change-Id: I3c4e29cb240e2a9a00bc9dd065ec85a5e8d8fe38
---
M src/libmsc/sdp_msg.c
1 file changed, 14 insertions(+), 5 deletions(-)
Approvals:
pespin: Looks good to me, approved
fixeria: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/libmsc/sdp_msg.c b/src/libmsc/sdp_msg.c
index cd721d3..9d787ad 100644
--- a/src/libmsc/sdp_msg.c
+++ b/src/libmsc/sdp_msg.c
@@ -179,20 +179,18 @@
if (codec->payload_type == payload_type)
return codec;
}
-
if (!create)
return NULL;
- /* Not found; codec points after the last entry now. */
- if ((codec - ac->codec) >= ARRAY_SIZE(ac->codec))
+ if (ac->count >= ARRAY_SIZE(ac->codec))
return NULL;
+ codec = &ac->codec[ac->count];
*codec = (struct sdp_audio_codec){
.payload_type = payload_type,
.rate = 8000,
};
-
- ac->count = (codec - ac->codec) + 1;
+ ac->count++;
return codec;
}
--
To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35876?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-Change-Id: I3c4e29cb240e2a9a00bc9dd065ec85a5e8d8fe38
Gerrit-Change-Number: 35876
Gerrit-PatchSet: 3
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-MessageType: merged
