Patch Set 3: (2 comments)
https://gerrit.osmocom.org/#/c/5752/3/src/osmo-bsc/osmo_bsc_bssap.c File src/osmo-bsc/osmo_bsc_bssap.c: Line 367: > (unrelated whitespace change) This empty line was added intentionally for visual spacing. Are we trying to avoid such extra blank lines in osmocom? Line 392: if (page_subscriber(msc, bts, tmsi, lac, mi_string, chan_needed) < 0) > I see that the only failure page_subscriber() returns is currently a failur OK, the new patchset keeps iterating the BTS list in case of failure. -- To view, visit https://gerrit.osmocom.org/5752 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c72c7f83e53988eb9fedf314b1dc459836833d Gerrit-PatchSet: 3 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Stefan Sperling <ssperl...@sysmocom.de> Gerrit-HasComments: Yes
