Attention is currently required from: lynxis lazus, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email )
Change subject: ttcn3-epdg: Use new 'pre-create tundev' feature from gtp_u_kmod ...................................................................... Patch Set 3: (3 comments) File osmo-epdg-master/Dockerfile: https://gerrit.osmocom.org/c/docker-playground/+/35994/comment/b8c89cc0_a41adac1 PS3, Line 14: USER build How about we use current master of libgtpnl-tools from git instead? since typically we want to ensure that current master of everything works nicely together, and so we could use/test newer features added to the libgtpnl tools (like binding to specific IP addresses what you proposed) without waiting for a new release. If you agree, two ways we could do it: * build it from source here * add the nightly repository here and install it from there. IMHO the "# Add osmocom latest repo, should we ever require packages from there" block from debian-bookworm-erlang can be removed, the only other container using this image is osmo_dia2gsup-master and it doesn't install packages from osmocom:latest (and if it did, I also think it would make more sense to use master/nightly) File ttcn3-epdg-test/osmo-epdg.sh: https://gerrit.osmocom.org/c/docker-playground/+/35994/comment/c94daa12_a64ffd80 PS3, Line 1: #!/bin/bash This script gets executed with /bin/sh in ttcn3-epdg-test/jenkins.sh, so I'd change it to #!/bin/sh here as well to avoid confusion. https://gerrit.osmocom.org/c/docker-playground/+/35994/comment/c8f58923_52f9d25e PS3, Line 9: # gtp-link needs to be kept running in order for osmo-epdg to be able to set up PDP contexts... remove the unused/commented out lines with MYPID, and add the comment on top of the gtp-link line instead? -- To view, visit https://gerrit.osmocom.org/c/docker-playground/+/35994?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: docker-playground Gerrit-Branch: master Gerrit-Change-Id: Ie7e2b4fadef69c889b12792fc2b8050f1ef5c684 Gerrit-Change-Number: 35994 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: lynxis lazus <[email protected]> Gerrit-Comment-Date: Fri, 16 Feb 2024 09:56:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
