laforge has submitted this change. (
https://gerrit.osmocom.org/c/pysim/+/36012?usp=email )
Change subject: pylint: esim/saip/validation.py
......................................................................
pylint: esim/saip/validation.py
pySim/esim/saip/validation.py:95:42: C0117: Consider changing "not not ('usim'
in m_svcs or 'isim' in m_svcs)" to "'usim' in m_svcs or 'isim' in m_svcs"
(unnecessary-negation)
pySim/esim/saip/validation.py:129:0: C0305: Trailing newlines
(trailing-newlines)
Change-Id: Idcc9871d6a7068e8aedbd8cd81f4156918af5e50
---
M pySim/esim/saip/validation.py
1 file changed, 13 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
diff --git a/pySim/esim/saip/validation.py b/pySim/esim/saip/validation.py
index acf1864..f9f5773 100644
--- a/pySim/esim/saip/validation.py
+++ b/pySim/esim/saip/validation.py
@@ -92,7 +92,7 @@
raise ProfileError('get-identity mandatory, but no usim or isim')
if 'profile-a-x25519' in m_svcs and not ('usim' in m_svcs or 'isim' in
m_svcs):
raise ProfileError('profile-a-x25519 mandatory, but no usim or
isim')
- if 'profile-a-p256' in m_svcs and not not ('usim' in m_svcs or 'isim'
in m_svcs):
+ if 'profile-a-p256' in m_svcs and not ('usim' in m_svcs or 'isim' in
m_svcs):
raise ProfileError('profile-a-p256 mandatory, but no usim or isim')
FileChoiceList = List[Tuple]
@@ -126,4 +126,3 @@
def check_forbidden(self, l: FileChoiceList):
"""Perform checks for forbidden parameters as described in Section
8.3.3."""
-
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36012?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Idcc9871d6a7068e8aedbd8cd81f4156918af5e50
Gerrit-Change-Number: 36012
Gerrit-PatchSet: 2
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-MessageType: merged
