Attention is currently required from: laforge.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email )

Change subject: VTY: rename 'sctp-role' to 'transport-role', add an alias
......................................................................


Patch Set 4:

(1 comment)

File tests/vty/ss7_asp_test.vty:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35978/comment/2fdc9008_e2cb2b5a
PS2, Line 425:   role sg
             :   transport-role ser
> This is one of the reasons why I've always been advocating for the 'only save 
> those parameters which […]
I am one of those people who don't like omitting default values in the output 
of `show running-config` / `write file` commands. Because of that, you need 
additional sources of information (like the VTY reference or source code) when 
editing a config file. And it's not always clearly stated in the VTY reference 
PDFs what's the default value for a certain command, so this is when I go check 
the source code. It's not a big deal for me, but definitely not that easy for a 
regular user without programming skills.

In any case, I don't think it's worth discussing this problem here in such a 
scope limited place. If you have a better idea of how could this be 
implemented, please let me know. I am not going to defend the current approach.



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35978?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: Iab6c898181d79a5ed2bea767ee90e55bc3af16a5
Gerrit-Change-Number: 35978
Gerrit-PatchSet: 4
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Tue, 20 Feb 2024 19:40:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to