Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/36037?usp=email )
Change subject: input/ipaccess: Always log with context, if we have any ...................................................................... Patch Set 1: (3 comments) File src/input/ipaccess.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549): https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/3325de40_0ebc380f PS1, Line 600: LOGPIL(line, DLINP, LOGL_NOTICE, "Keepalive is set: %i\n", ret); Use %d instead of %i Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549): https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/48b6c74f_113543b1 PS1, Line 979: " port=%u msg_type=%u\n", link->port, msg_type); code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14549): https://gerrit.osmocom.org/c/libosmo-abis/+/36037/comment/bae5aeff_140570d9 PS1, Line 1072: "OML connecting to %s:%u\n", line->ops->cfg.ipa.addr, IPA_TCP_PORT_OML); code indent should use tabs where possible -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/36037?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I5cd84c2d69c0db3be296cb5d9a62720f7b2c827e Gerrit-Change-Number: 36037 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <[email protected]> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 21 Feb 2024 16:44:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
