Attention is currently required from: laforge, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email )
Change subject: Use osmocom gtplib pointing to newer version of code ...................................................................... Patch Set 3: (3 comments) File rebar.config: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/a81cf836_091874c0 PS3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib";, {branch, "osmocom/master"}}}, wouldn't it be better to use an exact commit instead? that way it would be clear from git history which commit was used at which time File rebar.lock: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/4ad6f843_7e95a89a PS3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}}, * unrelated change * just so I understand it, why is this using osmocom/master for osmo_gsup instead of master/a commit from master? https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/faf6a3b2_b5b96680 PS3, Line 37: {git,"https://github.com/uwiger/parse_trans.git";, unrelated change (unlike gitlab, there is no git redirect if using github urls without .git) -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaf2e195aaeac6d1b157a4b0dd6cd3d80deaa1308 Gerrit-Change-Number: 36052 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: lynxis lazus <[email protected]> Gerrit-CC: osmith <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 23 Feb 2024 09:27:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
